feat!: bump node and nextjs verison + general upgrades #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit upgrades versions and adds a few quality of life features like environment variable checking
✅ Deploy Preview for cesium-hydrogen-new ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
afonsopimenta
requested review from
ruioliveira02,
GresosJ,
diogogmatos,
EnzoVieira and
ruilopesm
|
Some one needs to disable Build and style branch protection rules in the repo settings, or bump the node version there as well. It's still trying to test the branch in the previous version and it's been stuck for hours. |
afonsopimenta
changed the title
ruilopesm
requested changes
Mar 10, 2024
| @@ -15,7 +15,7 @@ jobs: | |||
|
|
|||
| strategy: | |||
| matrix: | |||
| node-version: ["18.12.0"] | |||
| node-version: ["21.5.0"] | |||
There was a problem hiding this comment.
Suggested change
| node-version: ["21.5.0"] | |
| node-version: ["20.11.1"] |
Prefer using LTS versions
| @@ -11,7 +11,7 @@ jobs: | |||
|
|
|||
| strategy: | |||
| matrix: | |||
| node-version: ["18.12.0"] | |||
| node-version: ["21.5.0"] | |||
There was a problem hiding this comment.
Suggested change
| node-version: ["21.5.0"] | |
| node-version: ["20.11.1"] |
| @@ -1 +1 @@ | |||
| nodejs 18.12.0 | |||
| nodejs 21.5.0 | |||
There was a problem hiding this comment.
Suggested change
| nodejs 21.5.0 | |
| nodejs 20.11.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades node and nextjs version to take advantage of next's new features (mostly appdir not being experimental anymore and next font most recent optimizations)
Also adds some quality of life features like checking environment variables for type safety at build time.
Some linting rules were added and can still be discussed and subject to change. There are still some places that had to be lint-ignored due to these new rules, but if the rules stay I will deal with the problems in another PR.